chore: bundle the root package.json as an installable package #32544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AtofStryker
force-pushed
the
chore/bundle_package_root
branch
2 times, most recently
from
8033db1 to
ba709b7
Compare
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/bundle_package_root
|
| Run status |
|
| Run duration | 21m 02s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
28
|
Skipped
|
0
|
Passing
|
791
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
63.16%
|
|
|---|---|
|
Untested elements
|
26
|
|
Tested elements
|
48
|
Accessibility
99.02%
|
|
|---|---|
|
Failed rules
|
0 critical
3 serious
1 moderate
0 minor
|
|
Failed elements
|
19
|
AtofStryker
force-pushed
the
chore/bundle_package_root
branch
from
ba709b7 to
e318df5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jennifer-shehane
approved these changes
Sep 30, 2025
cacieprins
approved these changes
Sep 30, 2025
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
cacieprins
pushed a commit
that referenced
this pull request
Oct 1, 2025
* chore: bundle the root package.json as an installable package * Update packages/root/README.md Co-authored-by: Jennifer Shehane <jennifer@cypress.io> * Update guides/esm-migration.md Co-authored-by: Jennifer Shehane <jennifer@cypress.io> * Update packages/root/README.md Co-authored-by: Jennifer Shehane <jennifer@cypress.io> --------- Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
changes
@packages/rootto bundle the rootpackage.jsonso@packages/rootcan be an true installable package. This means that regardless of where the package is installed, it will always be able to "discover" the rootpackage.json, which is used in a few packages, such as theconfig,types, etc.What this means, is instead of trying to discover the root package relative to itself, we now directly bundle the root
package.jsoninto the@packages/rootbundle viarollupCommonJS bundle file
ESM bundle file
we currently need both outputs in order to consume ESM in the browser via
vite(app and launchpad) and CJS to consume the package in the node process (server, data-context, etc)This step is crucial in order to make the other packages bundle from source.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Introduce a built @packages/root that bundles the repo’s package.json (CJS+ESM) with build tooling updates, CI filter tweaks, and dependency bumps.
index.ts) and bundle rootpackage.jsonvia Rollup, outputtingindex.js(CJS) andindex.mjs(ESM).rollup.config.mjs,tsconfig.json, build scripts,.gitignore, and README; updatepackage.json(description, scripts, devDeps,module).scripts/binary/build.ts, write rootpackage.jsonversionduring build; remove version update frompackageElectronApp.chore/bundle_package_root.packages/rootas completed inguides/esm-migration.md; adjustBUGBOT.mdpackage note.@rollup/plugin-json; bumprollupto4.52.0(with platform bins); addtypescript@^5.6.3.Written by Cursor Bugbot for commit 8093bd8. This will update automatically on new commits. Configure here.